PhysicsServer2D: Correct safe margin in test_body_motion
#111982
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasasdhba
changed the title
test_body_motiontest_body_motion
dasasdhba
force-pushed
the
PhysicsServer2D--Correct-safe-margin-in-`test_body_motion`
branch
from
175d1aa to
4343dc9
Compare
AThousandShips
added
the
cherrypick:4.5
dasasdhba
force-pushed
the
PhysicsServer2D--Correct-safe-margin-in-`test_body_motion`
branch
from
4343dc9 to
053a492
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111059 in another approach, this may also close #57706
The latter one is not fully tested, it's hard to track the issue with that MRP. My testing results are as follows:
Before fix:
After fix:
You may check explanation in my previous PR
Since it's a change in
PhysicsServer, It will possibly affect something else, further testings are desired.